I just got one myself recently...iPod may have a few small problems, but nothing should prevent someone from getting one. The biggest problem, battery life, has pretty much been solved in the new generation. (a low-end 8 hours to a much more acceptable 12)
Other players may have individual advantages over the iPod, but no player one-uped it in every catagory. No competitor is so overall good. The iPod is just such a great overall user experience...easy setup, easy to import music onto iTunes, easy to transfer music from iTunes onto iPod (pretty much completely automatic by default), and most importantly, easy use.
Everything's just so slick, and it really 'just works'......and it works admirably well too. Seriously. Highly recommended.