[mlevit]

<SCRIPT LANGUAGE="JavaScript">




<!-- Begin
var expDays = 2; // number of days the cookie should last

var page = "upcoming_events.html";
var windowprops = "width=400,height=200,left = 40,top = 40,location=no,toolbar=no,menubar=no,scrollbars=yes,resizable=no";

function GetCookie (name) {  
var arg = name + "=";  
var alen = arg.length;  
var clen = document.cookie.length;  
var i = 0;  
while (i < clen) {    
var j = i + alen;    
if (document.cookie.substring(i, j) == arg)      
return getCookieVal (j);    
i = document.cookie.indexOf(" ", i) + 1;    
if (i == 0) break;   
}  
return null;
}
function SetCookie (name, value) {  
var argv = SetCookie.arguments;  
var argc = SetCookie.arguments.length;  
var expires = (argc > 2) ? argv[2] : null;  
var path = (argc > 3) ? argv[3] : null;  
var domain = (argc > 4) ? argv[4] : null;  
var secure = (argc > 5) ? argv[5] : false;  
document.cookie = name + "=" + escape (value) + 
((expires == null) ? "" : ("; expires=" + expires.toGMTString())) + 
((path == null) ? "" : ("; path=" + path)) +  
((domain == null) ? "" : ("; domain=" + domain)) +    
((secure == true) ? "; secure" : "");
}
function DeleteCookie (name) {  
var exp = new Date();  
exp.setTime (exp.getTime() - 1);  
var cval = GetCookie (name);  
document.cookie = name + "=" + cval + "; expires=" + exp.toGMTString();
}
var exp = new Date(); 
exp.setTime(exp.getTime() + (expDays*24*60*60*1000));
function amt(){
var count = GetCookie('count')
if(count == null) {
SetCookie('count','1')
return 1
}
else {
var newcount = parseInt(count) + 1;
DeleteCookie('count')
SetCookie('count',newcount,exp)
return count
   }
}
function getCookieVal(offset) {
var endstr = document.cookie.indexOf (";", offset);
if (endstr == -1)
endstr = document.cookie.length;
return unescape(document.cookie.substring(offset, endstr));
}

function checkCount() {
var count = GetCookie('count');
if (count == null) {
count=1;
SetCookie('count', count, exp);

window.open(page, "", windowprops);

}
else {
count++;
SetCookie('count', count, exp);
   }
}
//  End -->
</script>

The above is the code i have obtained (because i myself dont really know Javascript or how to set cookies etc)

There is also a "onLoad" statement in the body of the code that runs "checkCount()"

What the code should do: This code show check whether you have a cookie and if you dont, it will pop up with a window. Now the cookie should then be set for 2 days, and within those 2 days the pop up will not appear if you visit that same page.

Problem: When the code is executed, and you do not have a cookie, the pop up comes up and the cookie is set. If you visit again, there will not be another pop up, but a new cookie is set starting at the new date and time. So what this means is that there will never be another pop up. Because each time it checks for a new cookie it just sets another one for 2 days.

Can somebody please help me with this?

[Emily]

Before creating a new cookie, just check if the cookie with the same name already exists. Only create a new cookie if it doesn't already exist.

[mlevit]

You probably missed it, but i mentioned above that i obtained the code from a free website, because although i am doing Computer Science in uni i dont know Javascript.

So i was just wondering if someone here could spot the error in the script.

[Emily]

I don't know Javascript very well either. From what I can see which is probably not very much, in checkCount() it creates a cookie whether or not GetCookie() returns null. Just for kicks try replacing:

function checkCount() {
var count = GetCookie('count');
if (count == null) {
count=1;
SetCookie('count', count, exp);

window.open(page, "", windowprops);

}
else {
count++;
SetCookie('count', count, exp);
}
}

with:

function checkCount() {
var count = GetCookie('count');
if (count == null) {
count=1;
SetCookie('count', count, exp);

window.open(page, "", windowprops);

}
}

[mlevit]

Thanks, it worked