View Single Post
Old 05-12-2008, 07:11 AM   #26 (permalink)
Osiris
Security/Hacking Mod
 
Osiris's Avatar
 
Join Date: Jan 2005
Location: USA
Posts: 24,120
Default Re: Osiris Spyware Scanner Download Beta 1

Quote:
Originally Posted by techpro5238 View Post
Hello Osiris,

I have run your program and I have a bit of constructive criticisms.

I will just list them in numbering as this will ease me of writing paragraphs.

----------------------------------------

1. Free Compilation - At the beginning of the program I had seen a warning at the top showing that you compiled it with a free program. It does not look professional to have advertising in your batch script

2. Coding Professionalism - Your program is fine for what it does .. but, the coding could be a bit better. If I had to guess at the source code, it runs a pause command then ends a few processes and runs the del command. Afterwards it will just report it couldn't find the file.

Maybe you should try using the IF EXIST and ELSE commands to ease all those del commands. Repetition in a spyware scanner is sort of annoying for analysts.

3. Logs - In the analyst field where we do not just analyze HJTs (as they give the less of all information that any log gives) we need logs to understand the computers we work with.

I believe your program should create a log of its own. If you need any assistance with getting it to create a log, feel free to send a PM over to me.

4. Usage and Copyrighting - Like I said in my last post, you need to direct exactly what this tool does.

Will it just be a scanner and remove malware? If so, it should just be an anti-spyware or anti-virus. In that way, you should code it in C, C++, or Delphi. If not, you should have it do a bit more than just scan such as resetting system entries or something to that effect.

On the Copyrighting note, if you are going to put more work into this program you should copyright it so no others can steal your database list. Also, if this is a GNU program, why can't I see the source code .

If you could host the main batch code, then I could look over the source and see what the program actually tasks.

What I lastly recommend, is you look at one of the tools that were professionally created such as ComboFix or S!ris Smitfraudfix. SMF, to my knowledge was created fully in batch scripts.

Feel free to comment back on my constructive criticism.

Kind Regards,
Techpro5238
Bout time I got some feedback

Question 1 - The program is not free that I used to convert the batch file to an .exe. I was going to "purchase" it when it was finished so thats why you see that there.

Question 2 - I'm not such a good coder, hence why It's just simple batch file commands. Thou I do agree this would run much faster if it was coded in C++, etc.

Question 3 - Still working on generating a log for what it finds/deletes.

Question 4 - I can add that

So what are you coding in for your tool?
Osiris is online now   Reply With Quote